Skip to content

Use Enum.Parse<TEnum> #4032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 67 commits into from
Sep 30, 2022
Merged

Use Enum.Parse<TEnum> #4032

merged 67 commits into from
Sep 30, 2022

Conversation

@lbargaoanu
Copy link
Contributor

@lbargaoanu lbargaoanu commented Jul 30, 2022 •
edited
Loading

I guess the diff is useless :) I could open another PR with the C# 10 stuff.

@lbargaoanu lbargaoanu added this to the 12.0.0 milestone Jul 30, 2022
@lbargaoanu lbargaoanu changed the title Use Enum.Parse<TEnum> Use Enum.TryParse<TEnum> Jul 30, 2022
@lbargaoanu lbargaoanu marked this pull request as draft July 30, 2022 05:14
@lbargaoanu lbargaoanu changed the title Use Enum.TryParse<TEnum> Use Enum.Parse<TEnum> Jul 30, 2022
@lbargaoanu lbargaoanu marked this pull request as ready for review July 30, 2022 05:25
@lbargaoanu lbargaoanu force-pushed the enum_parse branch 3 times, most recently from 7376883 to 667a3d5 Compare July 30, 2022 10:04
@lbargaoanu lbargaoanu force-pushed the enum_parse branch 2 times, most recently from 333b638 to 77086e8 Compare July 31, 2022 10:52
@lbargaoanu lbargaoanu force-pushed the enum_parse branch 2 times, most recently from fe67877 to e3aecd3 Compare August 2, 2022 06:49
@lbargaoanu lbargaoanu force-pushed the enum_parse branch 3 times, most recently from f4e805d to 9fc7cdf Compare August 3, 2022 15:37
@lbargaoanu lbargaoanu force-pushed the enum_parse branch 4 times, most recently from 6bc5ab5 to 7fdf915 Compare August 5, 2022 15:57
@LuckyPennySoftware LuckyPennySoftware deleted a comment from orty Aug 5, 2022
@lbargaoanu lbargaoanu force-pushed the enum_parse branch 3 times, most recently from b10dc48 to b98273e Compare September 11, 2022 06:49
@lbargaoanu lbargaoanu force-pushed the enum_parse branch 3 times, most recently from a3c603c to 7da36f6 Compare September 13, 2022 08:44
@jbogard
Copy link
Contributor

jbogard commented Sep 13, 2022

I've got a request from Microsoft to push out this one: #3999, is this one close to wrapping?

@lbargaoanu
Copy link
Contributor Author

Sure.

@jbogard jbogard merged commit 73ba400 into master Sep 30, 2022
@jbogard jbogard deleted the enum_parse branch September 30, 2022 09:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jbogard jbogard jbogard approved these changes

Assignees

No one assigned

Labels

Improvement

Projects

None yet

Milestone

12.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@lbargaoanu @jbogard